Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo examples #11

Merged
merged 9 commits into from
Jun 25, 2024
Merged

Demo examples #11

merged 9 commits into from
Jun 25, 2024

Conversation

bigbrett
Copy link
Contributor

add skeleton for demos and a functional NVM demo example

@bigbrett bigbrett marked this pull request as ready for review June 14, 2024 16:40
Copy link
Contributor

@jpbland1 jpbland1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just think we should remove the dead code

#include "wolfhsm/wh_error.h"


static void doWorkWithKey(uint16_t keyId)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets just axe this, it's fine for the cache and commit examples to be standalone.

@bigbrett bigbrett requested a review from jpbland1 June 25, 2024 19:10
Copy link
Contributor

@jpbland1 jpbland1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, merging

@jpbland1 jpbland1 merged commit 62ebf7c into wolfSSL:main Jun 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants